Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Rust Error types #2474

Closed
ry opened this issue Jun 7, 2019 · 1 comment · Fixed by #2487
Closed

Unify Rust Error types #2474

ry opened this issue Jun 7, 2019 · 1 comment · Fixed by #2487

Comments

@ry
Copy link
Member

ry commented Jun 7, 2019

We currently have

core::JSError
cli::JSErrorWithColor
cli::Diagnostics
cli::DenoError
cli::RustOrJSError

Everything needs to go into DenoError, except core::JSError.

@ry ry mentioned this issue Jun 7, 2019
43 tasks
@kitsonk
Copy link
Contributor

kitsonk commented Jun 10, 2019

I am working on this.

@kitsonk kitsonk mentioned this issue Jun 10, 2019
4 tasks
@ry ry closed this as completed in #2487 Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants