LSP: Formatting ignores passed formatting options

[mkhl]

Version: Deno 1.42.0

When the Deno LSP receives a textDocument/formatting request, it receives an optional set of formatting options with that request, see DocumentFormattingParams and FormattingOptions in the LSP spec.

The request gets handled by the formatting function, and it receives the DocumentFormattingParams but only handles the contained reference to the text document and ignores the formatting options, instead generating its own formatting options for the document.

The expected behavior should be that it instead respects the received formatting options and formats the document according to them, falling back on defaults it provides itself.

[heygarrett]

Expanding on my comment here, the editor settings taking priority over the project settings feels backwards. When I use Prettier or Biome, my editor formats according to the project settings, and I'm sure most people would expect Deno to function similarly. Otherwise, one would need to manually change their editor settings to match the project settings for each project they're contributing to.