Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jupyter-kernel] Deno enabled in VScode breaks notebooks #20955

Closed
karelklima opened this issue Oct 22, 2023 · 2 comments
Closed

[jupyter-kernel] Deno enabled in VScode breaks notebooks #20955

karelklima opened this issue Oct 22, 2023 · 2 comments

Comments

@karelklima
Copy link

karelklima commented Oct 22, 2023

Deno language features within Jupyter notebooks do not work in VScode if Deno is enabled in the workspace.

System:

  • Windows 10
  • Deno 1.37.2
  • Python 3.12.0
  • VS Code: 1.83.1
  • Deno vscode extension: 3.26.0
  • Jupyter vscode extension: 2023.9.1102792234

Steps to reproduce:

  • create an empty folder and open it in VS Code
  • create a Jupyter Notebook file, select Deno kernel and TypeScript language
  • in the Notebook, create a variable in one code block and reference it in a second code block - at this point everything works
  • create deno.json file
  • go to the Jupyter Notebook file - at this point the deno autocomplete is broken, the variable reference does not work anymore

image

@karelklima karelklima changed the title [jupyter-kernel] deno.json in VScode breaks notebooks [jupyter-kernel] Deno enabled in VScode breaks notebooks Oct 22, 2023
@nayeemrmn
Copy link
Collaborator

This is tracked in denoland/vscode_deno#932. The same thing would happen with Deno disabled if you used imports in one of the cells, it's just that Deno is always in ESM mode.

@karelklima
Copy link
Author

@nayeemrmn Thanks for referencing and closing this issue, I didn't find that before posting this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants