Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the network domain for Deno's debugger #20417

Open
tmcw opened this issue Sep 8, 2023 · 1 comment
Open

Support for the network domain for Deno's debugger #20417

tmcw opened this issue Sep 8, 2023 · 1 comment
Labels
debugger Chrome DevTools inspector/debugger integration feat new feature (which has been agreed to/accepted)

Comments

@tmcw
Copy link

tmcw commented Sep 8, 2023

This protocol (the V8 inspector protocol) is extensible and there is a version of it which includes the ability to intercept, record, and rewrite Fetch requests:

https://github.com/ChromeDevTools/devtools-protocol/blob/322248d8ad7c322817fd2557191454cc4a9b3a1e/json/browser_protocol.json#L22194

Over in the land of Node, there was a discussion of supporting this protocol, but it got closed because of staleness: nodejs/diagnostics#75

It'd be pretty nice to be able to debug network traffic with the debugger, and it'd also make the experience of using Deno another step closer to that of other "web javascript" environments like Chrome!

@bartlomieju
Copy link
Member

We actually had an attempt like this in the past, where @lucacasonato implemented a working prototype in: #11660

One problem we faced was that we were consuming memory like crazy (because all the response bodies and WS messages were being stashed for inspection), but maybe it's not a huge deal when running with --inspect flag. That code is not really usable anymore, but it could certainly be revived. Maybe the architecture be much cleaner now that we have extension! macro. All that said, I'd love this feature and was supposed to finish it two years ago, but my bandwidth is extremely limited right now.

@bartlomieju bartlomieju added feat new feature (which has been agreed to/accepted) debugger Chrome DevTools inspector/debugger integration labels Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debugger Chrome DevTools inspector/debugger integration feat new feature (which has been agreed to/accepted)
Projects
None yet
Development

No branches or pull requests

2 participants