bcrypt is broken on canary version of deno

[ralyodio]

Use deno upgrade --canary and the bcrypt.compare(pw, hashed_pw) function no longer works on accounts created before upgrading. Accounts created using canary DO work.

If you downgrade back to 1.22 deno upgrade (remove --canary flag) older accounts can now login but newer accoutns created on --canary can NOT login anymore.

[neves]

Confirmed, 1.22.3 is the last working version

[cjihrig]

This may be related to #14900

[neves]

It is, looks like bcrypt 0.4.0 got it fixed JamesBroadberry/deno-bcrypt@fb6e55a#diff-1e6ca9cef64c48c0a1b40625392ef7400279ef9a23d3ccd80e933c5ee51f2e1dR1196

[JamesBroadberry]

Hey, yeah we've had an issue tracking what happened with it and remedial action to be taken. Either use Deno < 1.23.0 or use bcrypt 0.4.0 for now or the entire cipher gets bypassed due to a change with how the code is transpiled.

This issue has also been raised and fixed in the bcrypt repository.

JamesBroadberry/deno-bcrypt#27
JamesBroadberry/deno-bcrypt#28

Fixed in v0.4.0
https://github.com/JamesBroadberry/deno-bcrypt/releases/tag/v0.4.0