Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno test --jobs flag should require equals when passing a value #14533

Closed
nayeemrmn opened this issue May 8, 2022 · 4 comments · Fixed by #15259
Closed

deno test --jobs flag should require equals when passing a value #14533

nayeemrmn opened this issue May 8, 2022 · 4 comments · Fixed by #15259
Labels
breaking change a change or feature that breaks existing semantics bug Something isn't working correctly testing related to deno test and coverage

Comments

@nayeemrmn
Copy link
Collaborator

The --jobs flag optionally doesn't take a number value to default to the number of available cpus. So it should require an equal sign. Currently deno test --jobs tests/ doesn't work because tests/ is parsed as the number of threads. Unfortunately this is a breaking change, so this was a bad oversight.

@bartlomieju bartlomieju added bug Something isn't working correctly testing related to deno test and coverage labels May 8, 2022
@hyperliskdev
Copy link

I think I'd like to try and work on this.

@dsherret
Copy link
Member

When fixing this (aka, doing this breaking change) we should consider whether we should just deprecate it in favour of the DENO_JOBS env variable. See discussion in #14929 (comment)

@dsherret dsherret added the breaking change a change or feature that breaks existing semantics label Jul 15, 2022
@nayeemrmn
Copy link
Collaborator Author

Note that we also wanted some binary flag to activate DENO_JOBS so that the test runner remained single-threaded by default. Other than retracting that expectation, a sound option would be to still deprecate --jobs and replace it with --parallel which does the same thing. It's a slightly better name for a binary flag and wouldn't have this bug.

@dsherret
Copy link
Member

I think replacing it with --parallel makes sense given that fixing --jobs is a breaking change and it's not a great name. Also, "parallel": true in the configuration file might be a nice option in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change a change or feature that breaks existing semantics bug Something isn't working correctly testing related to deno test and coverage
Projects
None yet
4 participants