Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AbortSignal.timeout() #13582

Closed
andreubotella opened this issue Feb 3, 2022 · 2 comments · Fixed by #13687
Closed

Implement AbortSignal.timeout() #13582

andreubotella opened this issue Feb 3, 2022 · 2 comments · Fixed by #13687
Labels
ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted) web related to Web APIs

Comments

@andreubotella
Copy link
Contributor

See whatwg/dom#1032.

I'll probably take care of this, unless @crowlKats or someone else wants to do it.
@lucacasonato lucacasonato added ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted) web related to Web APIs labels Feb 3, 2022
@crowlKats
Copy link
Member

@andreubotella feel free to do it

@andreubotella
Copy link
Contributor Author

This would introduce a circular dependency between the ext crates: with AbortSignal.timeout(), ext/web would have to depend on ext/timers, but because Performance.prototype.measure() can throw a DOMException, ext/timers also depends on ext/web.

How do we solve this? Should performance be moved to a separate crate? Should AbortSignal.timeout() be defined in ext/timers?

This was referenced Feb 13, 2022
Merged
Merged
andreubotella added a commit to andreubotella/deno that referenced this issue Feb 16, 2022
@andreubotella
feat(ext/web): Add AbortSignal.timeout().
faf489b 
Closes denoland#13582.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ext/web related to the ext/web crate feat new feature (which has been agreed to/accepted) web related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ext/web): Add AbortSignal.timeout(). andreubotella/deno
3 participants
@lucacasonato @andreubotella @crowlKats