Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring proxy via ALL_PROXY environment variable #12080

Open
kidonng opened this issue Sep 15, 2021 · 2 comments
Open

Support configuring proxy via ALL_PROXY environment variable #12080

kidonng opened this issue Sep 15, 2021 · 2 comments
Labels
ext/http related to ext/http feat new feature (which has been agreed to/accepted)

Comments

@kidonng
Copy link
Contributor

kidonng commented Sep 15, 2021 •
edited
Loading

Right now Deno only looks for HTTP_PROXY, HTTPS_PROXY and NO_PROXY for proxy configuration. It would be more convenient to support ALL_PROXY which controls all protocols.

Popular programs like curl and Homebrew all respects ALL_PROXY and IMO Deno should follow suit, unless there is a reason not to.
@bartlomieju bartlomieju added the suggestion suggestions for new features (yet to be agreed) label Oct 5, 2021
@bartlomieju
Copy link
Member

I think this is quite reasonable. PRs implementing this feature are welcome.

@kidonng
Copy link
Contributor Author

kidonng commented Dec 26, 2021

Just realized this is handled by reqwest, not Deno. Upstream: seanmonstar/reqwest#1414

@lucacasonato lucacasonato added feat new feature (which has been agreed to/accepted) ext/http related to ext/http and removed suggestion suggestions for new features (yet to be agreed) labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ext/http related to ext/http feat new feature (which has been agreed to/accepted)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucacasonato @bartlomieju @kidonng