Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno test --doc should be able to typecheck Markdown files #11170

Closed
bartlomieju opened this issue Jun 29, 2021 · 1 comment · Fixed by #11421
Closed

deno test --doc should be able to typecheck Markdown files #11170

bartlomieju opened this issue Jun 29, 2021 · 1 comment · Fixed by #11421
Labels
suggestion suggestions for new features (yet to be agreed) tests related to tests

Comments

@bartlomieju
Copy link
Member

bartlomieju commented Jun 29, 2021

deno test --doc should typecheck codeblocks in Markdown files by default.

It will make it easier to keep documentation up to date, especially keeping Deno manual examples working on each commit.

Doing so will keep it inline with deno fmt and deno lint which can already act on Markdown files.

CC @caspervonb

@caspervonb
Copy link
Contributor

caspervonb commented Jul 16, 2021

I've implemented this in #11421 but... we do make use of a special marker STD_VERSION which means these fenced code blocks aren't currently valid so we need to either remove that or work around it somehow without making the test runner even more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion suggestions for new features (yet to be agreed) tests related to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants