-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to ignore deno(deno-warn) warns in VSCode #10822
Comments
This is working as designed. There is no way to ignore it, it is a warning that you are implicitly using a version which is risky. You are welcome to ignore the warning. |
@kitsonk There should be a quick-fix available to convert it to the latest version, automatically. Also, I think there should be a way to ignore warnings (i.e. on next line using a comment), for the people who prefer to load the most recent version. Yes it's risky, but it's not your choice to decide if it's right or wrong. The warning makes it clear enough. Please rethink your choice on this issue. Thank you in advance. |
I agree, I like "the warning makes it clear enough". |
You get the same warning for standard libs, which is understandable since they are just URLs being imported, however, it's fairly standard practice to import standard libraries using the latest version isn't it? Having a quick fix option to ignore the rule for the file or line would be a nice addition to the extension. Alternately, and maybe not the best idea, would be to not run that rule for standard lib imports. Does the linter accept that kind of specific exception? |
Not really. All imports should always be versioned. |
@johnschult it is not recommended to use latest version of standard library. It is still unstable and breaking changes are happening between versions. |
Actually, not correct. |
@kitsonk Thanks for the pointer 😄 |
FWIW, I also deeply disagree with this. I have developer tools that I wish to use the latest std library version without having to constantly update their source to specify that. @martin-braun is perfectly correct; there may be considerations but it ought to be our choice when to do this, not yours. Otherwise all code files in VSCode get highlighted as having "problems" which are not problems at all, but a deliberate choice. Respectfully, please reconsider. |
Implicitly using latest version (v0.1.9-alpha) for https://deno.land/x/deno_dom/deno-dom-wasm.tsdeno(deno-warn)
Example:
The text was updated successfully, but these errors were encountered: