Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to ignore deno(deno-warn) warns in VSCode #10822

Closed
Hunam6 opened this issue Jun 2, 2021 · 9 comments
Closed

Unable to ignore deno(deno-warn) warns in VSCode #10822

Hunam6 opened this issue Jun 2, 2021 · 9 comments
Labels
working as designed this is working as intended

Comments

@Hunam6
Copy link

Hunam6 commented Jun 2, 2021

Implicitly using latest version (v0.1.9-alpha) for https://deno.land/x/deno_dom/deno-dom-wasm.tsdeno(deno-warn)

Example:
image

@Hunam6 Hunam6 changed the title Unable to disable deno(deno-warn) warns in VSCode Unable to ignore deno(deno-warn) warns in VSCode Jun 2, 2021
@kitsonk kitsonk added the working as designed this is working as intended label Jun 3, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Jun 3, 2021

This is working as designed. There is no way to ignore it, it is a warning that you are implicitly using a version which is risky. You are welcome to ignore the warning.

@kitsonk kitsonk closed this as completed Jun 3, 2021
@martin-braun
Copy link

@kitsonk There should be a quick-fix available to convert it to the latest version, automatically. Also, I think there should be a way to ignore warnings (i.e. on next line using a comment), for the people who prefer to load the most recent version. Yes it's risky, but it's not your choice to decide if it's right or wrong. The warning makes it clear enough.

Please rethink your choice on this issue. Thank you in advance.

@Hunam6
Copy link
Author

Hunam6 commented Aug 16, 2021

@kitsonk There should be a quick-fix available to convert it to the latest version, automatically. Also, I think there should be a way to ignore warnings (i.e. on next line using a comment), for the people who prefer to load the most recent version. Yes it's risky, but it's not your choice to decide if it's right or wrong. The warning makes it clear enough.

Please rethink your choice on this issue. Thank you in advance.

I agree, I like "the warning makes it clear enough".

@johnschult
Copy link

You get the same warning for standard libs, which is understandable since they are just URLs being imported, however, it's fairly standard practice to import standard libraries using the latest version isn't it? Having a quick fix option to ignore the rule for the file or line would be a nice addition to the extension.

Alternately, and maybe not the best idea, would be to not run that rule for standard lib imports. Does the linter accept that kind of specific exception?

Screen Shot 2021-11-01 at 6 13 50 AM

@lucacasonato
Copy link
Member

however, it's fairly standard practice to import standard libraries using the latest version isn't it?

Not really. All imports should always be versioned.

@bartlomieju
Copy link
Member

@johnschult it is not recommended to use latest version of standard library. It is still unstable and breaking changes are happening between versions.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 1, 2021

@johnschult it is not recommended to use latest version of standard library. It is still unstable and breaking changes are happening between versions.

Actually, not correct. https://deno.land/std/ will always pull from the latest tag, which does not change between releases, but as @lucacasonato it is still recommended to use the version of std that is fixed and that the code is tested against.

@johnschult
Copy link

@kitsonk Thanks for the pointer 😄

@l-cornelius-dol
Copy link

l-cornelius-dol commented Jul 13, 2024

FWIW, I also deeply disagree with this. I have developer tools that I wish to use the latest std library version without having to constantly update their source to specify that. @martin-braun is perfectly correct; there may be considerations but it ought to be our choice when to do this, not yours. Otherwise all code files in VSCode get highlighted as having "problems" which are not problems at all, but a deliberate choice.

Respectfully, please reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
working as designed this is working as intended
Projects
None yet
Development

No branches or pull requests

7 participants