Remove assertion for empty modules (#1450)

denoland · Jan 4, 2019 · 6be1164 · 6be1164
1 parent 4f62a56
commit 6be1164
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/js/compiler.ts b/js/compiler.ts
@@ -244,7 +244,6 @@ export class Compiler
     }
     assert(moduleId != null, "No module ID.");
     assert(fileName != null, "No file name.");
-    assert(sourceCode ? sourceCode.length > 0 : false, "No source code.");
     assert(
       mediaType !== MediaType.Unknown,
       `Unknown media type for: "${moduleSpecifier}" from "${containingFile}".`

diff --git a/js/compiler_test.ts b/js/compiler_test.ts
@@ -52,7 +52,7 @@ function mockModuleInfo(
   };
 }
 
-// Some fixtures we will us in testing
+// Some fixtures we will use in testing
 const fooBarTsSource = `import * as deno from "deno";
 console.log(deno);
 export const foo = "bar";
@@ -227,6 +227,14 @@ const moduleMap: {
       "console.log('foo');",
       undefined,
       undefined
+    ),
+    "empty_file.ts": mockModuleInfo(
+      "/moduleKinds/empty_file.ts",
+      "/moduleKinds/empty_file.ts",
+      MediaType.TypeScript,
+      "",
+      undefined,
+      undefined
     )
   }
 };
@@ -637,3 +645,13 @@ test(function compilerResolveModuleNames() {
   }
   teardown();
 });
+
+test(function compilerResolveEmptyFile() {
+  setup();
+  const result = compilerInstance.resolveModuleNames(
+    ["empty_file.ts"],
+    "/moduleKinds"
+  );
+  assertEqual(result[0].resolvedFileName, "/moduleKinds/empty_file.ts");
+  teardown();
+});