Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock recovery #42

Open
denismo opened this issue Sep 6, 2013 · 0 comments
Open

Lock recovery #42

denismo opened this issue Sep 6, 2013 · 0 comments

Comments

@denismo
Copy link
Owner

denismo commented Sep 6, 2013

If a client system which took a look on file dies no other system will be able to lock its files. Worse, if the system restarts the in-memory lockId will be gone and the system itself won't be able to unlock.

Need to implement lock recovery - if the system is identified to be dead the locks should be released. It can be done by some other system, based on "last client check-in" time.

  1. The clients can check-in every now and then recording the time in some object.
  2. The other clients can read the check-in object in case of lock being held for long time, and compare it with the lock time (needs to be added as well). If the time is too far from the expected check-in another client can declare the other system dead and release its locks. Other clients would then only check the system status.
  3. Also depends on LockManager resiliance #41 to implement better error handling to handle situations when the client simply timed-out - if it is unable to lock/unlock on Dynamo it should not break the client. Unlock should succeed in most cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant