Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make embedded videos visible in the preview #1437

Open
2 of 8 tasks
SR-- opened this issue Sep 29, 2021 · 2 comments
Open
2 of 8 tasks

Make embedded videos visible in the preview #1437

SR-- opened this issue Sep 29, 2021 · 2 comments
Labels
area.misc type.feature New functionality

Comments

@SR--
Copy link

SR-- commented Sep 29, 2021

Please Select if your Request is Either something new or an Enhancement

  • Enhancement of an existing Feature.
  • Request of a new feature.

Please select the area your request applys to. (Multiple selections are Possible)

  • Onboard. Initial vault setup and import/export pods
  • Create. Note creation, lookup, snippets and templates
  • Retrieve. Backlinks, references, graph view
  • Structure. Refactoring, multi-vault and schemas
  • Publish. Sharing your repo with the world
  • Misc (Choose this if your not sure)

Is your feature request related to a problem? Please describe

Current preview in vscode does not show video embeds

Describe the solution you'd like

Show a playable video with a custom poster

Additional context

Discussion on Discord

@jonathanyeung
Copy link
Contributor

Hi @SR--, thanks for the feedback. Unfortunately, I don't think this is possible right now due to limitations in VS Code - their API doesn't support embedded videos right now. See microsoft/vscode#54097

@kevinslin can you confirm if this is the case?

@viztor
Copy link
Contributor

viztor commented Sep 29, 2021

Hi @SR--, thanks for the feedback. Unfortunately, I don't think this is possible right now due to limitations in VS Code - their API doesn't support embedded videos right now. See microsoft/vscode#54097

@kevinslin can you confirm if this is the case?

A related discussion microsoft/vscode#118275 advocated the inclusion of ffmpeg and discussed the possibility of bundling ffmpeg in vscode on one own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area.misc type.feature New functionality
Projects
None yet
Development

No branches or pull requests

3 participants