Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 improve Docker #409

Closed
ManAnRuck opened this issue Jun 15, 2018 · 0 comments
Closed

🛠 improve Docker #409

ManAnRuck opened this issue Jun 15, 2018 · 0 comments
Labels
🏛 Bundestag.io Repo: Development Repo: Server

Comments

@ManAnRuck
Copy link
Member

ManAnRuck commented Jun 15, 2018 •
edited
Loading

Description:
Yarn wird wohl häufiger als benötigt ausgeführt (bei jedem branch Wechsel) und erhöht damit unnötig die images sizes.

Faulty Behaviour:
Es gibt enorm viele Docker-layers

Expected Behaviour:
Keine doppelten layers.
Dies kann behoben werden, indem innerhalb des Containers yarn install ausgeführt wird und nicht schon beim builden (yarnpkg/yarn#749 (comment))
Ebenfalls würde dies das wechseln der branches vereinfachen, da theoretisch dann auch das yarn install ausgeführt wird und nicht erst beim manuellen Neustarten des servers

https://medium.com/@shemleong/using-docker-and-yarn-for-development-2546e567ad2
@ManAnRuck ManAnRuck added this to the MVP milestone Jun 15, 2018
@ulfgebhardt ulfgebhardt changed the title improve Docker 🛠 improve Docker Jul 13, 2018
@ulfgebhardt ulfgebhardt modified the milestones: MVP, Dream Sep 20, 2018
@ulfgebhardt ulfgebhardt removed this from the Ideas milestone Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏛 Bundestag.io Repo: Development Repo: Server
Projects
Democracy
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ulfgebhardt @ManAnRuck @visionmakery