Skip to content
This repository has been archived by the owner on Jan 25, 2018. It is now read-only.

Remove test duplication #8

Open
demizer opened this issue Oct 12, 2014 · 1 comment
Open

Remove test duplication #8

demizer opened this issue Oct 12, 2014 · 1 comment
Labels

Comments

@demizer
Copy link
Owner

demizer commented Oct 12, 2014

There are two files for tests:

logger_test.go
logger_std_test.go

logger_test.go tests features using a new logger object. logger_std_test.go uses the standard logger object.

We really only need to test the standard logging object. Tests in logger_std_test.go should not be duplicated in logger_test.go unless needed.

@demizer demizer added the Minor label Oct 12, 2014
@demizer
Copy link
Owner Author

demizer commented Oct 13, 2014

Removing would lower the test coverage score. Merging the tests so each test tests the standard logger and a logger object would be better... possibly.

@demizer demizer added Blocker and removed Minor labels Apr 6, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant