Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Whois] skipped unittest #30589

Merged
merged 9 commits into from
Nov 5, 2023
Merged

[Whois] skipped unittest #30589

merged 9 commits into from
Nov 5, 2023

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Oct 31, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Skipped test_socks_proxy unit test when using TEST_XDR_ENV

@michal-dagan michal-dagan changed the title test [Whois] skipped unittest Nov 2, 2023
@michal-dagan michal-dagan marked this pull request as ready for review November 5, 2023 09:06
@michal-dagan
Copy link
Contributor Author

@DeanArbel A force merge is needed as the coverage decreased after the unit test was put on comment

@michal-dagan michal-dagan added ForceMerge Forcing the merge of the PR despite the build status docs-approved labels Nov 5, 2023
@DeanArbel DeanArbel merged commit 2f015b8 into master Nov 5, 2023
20 checks passed
@DeanArbel DeanArbel deleted the test-whois branch November 5, 2023 09:49
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* test

* skip test_socks_proxy if TEST_XDR_ENV

* fixed

* fixed

* fixed Flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants