-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Expandr-6710 #30541
Merged
MosheEichler
merged 5 commits into
demisto:contrib/PaloAltoNetworks_EXPANDR-6710
from
PaloAltoNetworks:EXPANDR-6710
Oct 31, 2023
Merged
AWS Expandr-6710 #30541
MosheEichler
merged 5 commits into
demisto:contrib/PaloAltoNetworks_EXPANDR-6710
from
PaloAltoNetworks:EXPANDR-6710
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @capanw,
Thank you for your contribution!
Good work :)
Please see my comments,
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again.
MosheEichler
added
pending-contributor
The PR is pending the response of its creator
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
labels
Oct 31, 2023
melamedbn
approved these changes
Oct 31, 2023
MosheEichler
approved these changes
Oct 31, 2023
MosheEichler
merged commit Oct 31, 2023
c1ff56d
into
demisto:contrib/PaloAltoNetworks_EXPANDR-6710
24 of 25 checks passed
MosheEichler
added a commit
that referenced
this pull request
Oct 31, 2023
* AWS Expandr-6710 (#30541) * Initial commit * Script updates and playbook updates * removed additional files * fix yml * review fixes * Update Packs/AWS-Enrichment-Remediation/ReleaseNotes/1_1_7.md Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/AWS-Enrichment-Remediation/Scripts/AWSRecreateSG/AWSRecreateSG.yml Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/AWS-Enrichment-Remediation/Scripts/AWSRecreateSG/README.md Co-authored-by: ShirleyDenkberg <[email protected]> --------- Co-authored-by: Chait A <[email protected]> Co-authored-by: MosheEichler <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* AWS Expandr-6710 (#30541) * Initial commit * Script updates and playbook updates * removed additional files * fix yml * review fixes * Update Packs/AWS-Enrichment-Remediation/ReleaseNotes/1_1_7.md Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/AWS-Enrichment-Remediation/Scripts/AWSRecreateSG/AWSRecreateSG.yml Co-authored-by: ShirleyDenkberg <[email protected]> * Update Packs/AWS-Enrichment-Remediation/Scripts/AWSRecreateSG/README.md Co-authored-by: ShirleyDenkberg <[email protected]> --------- Co-authored-by: Chait A <[email protected]> Co-authored-by: MosheEichler <[email protected]> Co-authored-by: Moshe Eichler <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Contribution Form Filled
Whether contribution form filled or not.
Contribution
Thank you! Contributions are always welcome!
External PR
pending-contributor
The PR is pending the response of its creator
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Security Review
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6710
Description
Fixing an issue with AWSRecreateSG script
Must have