Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - ASM ServiceNow ITSM Enrichment & Service ID Fix #30478

Conversation

BigEasyJ
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Updated the playbook to make the input search_terms optional.

Must have

  • Tests
  • Documentation

Copy link
Contributor

@capanw capanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigEasyJ BigEasyJ changed the title [ASM] - ServiceNow ITSM Fix [ASM] - ASM ServiceNow ITSM Enrichment Fix Oct 26, 2023
@BigEasyJ BigEasyJ changed the title [ASM] - ASM ServiceNow ITSM Enrichment Fix [ASM] - ASM ServiceNow ITSM Enrichment & Service ID Fix Oct 27, 2023
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of changes @BigEasyJ made

@ilappe
Copy link
Contributor

ilappe commented Oct 29, 2023

@johnnywilkes
is this are ready for review by XSOAR team?

@melamedbn
Copy link
Contributor

@johnnywilkes is this are ready for review by XSOAR team?

@ilappe
Xpanse team do their own review for content within the Xpanse content pack

@melamedbn melamedbn removed their request for review October 29, 2023 12:18
@johnnywilkes
Copy link
Contributor

@ilappe , This has been approved from the Xpanse side.
please merge as soon as possible.

@ilappe ilappe merged commit 33ad583 into demisto:contrib/PaloAltoNetworks_servicenow-itsm-hotfix Oct 29, 2023
16 of 18 checks passed
ilappe pushed a commit that referenced this pull request Oct 29, 2023
)

* Update  search_terms to optional

* Update readme

* Add release notes

* EXPANDR-6808

---------

Co-authored-by: John <[email protected]>
Co-authored-by: jwilkes <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
)

* Update  search_terms to optional

* Update readme

* Add release notes

* EXPANDR-6808

---------

Co-authored-by: John <[email protected]>
Co-authored-by: jwilkes <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants