Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Prisma SASE by Palo Alto Networks - Content Pack Update #30360

Conversation

xsoar-bot
Copy link
Contributor

@xsoar-bot xsoar-bot commented Oct 23, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@SDarshna

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SDarshna for the contribution!

please see my few comments
you can click on the commit suggestion button

@ilappe ilappe added the pending-contributor The PR is pending the response of its creator label Oct 24, 2023
@ilappe
Copy link
Contributor

ilappe commented Oct 26, 2023

Thanks @SDarshna for implementing and testing the suggestion, and for the demo vidoe
i will continue with it to merge

@ilappe ilappe added post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed pending-contributor The PR is pending the response of its creator labels Oct 26, 2023
@ilappe ilappe self-requested a review October 26, 2023 09:34
Copy link
Contributor

@ilappe ilappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SDarshna!

@ilappe ilappe merged commit 5b89e43 into demisto:contrib/xsoar-contrib_SDarshna-contrib-PrismaAccess Oct 26, 2023
19 of 22 checks passed
DeanArbel pushed a commit that referenced this pull request Oct 29, 2023
…t Pack Update (#30360) (#30461)

* "contribution update to pack "Prisma SASE by Palo Alto Networks""

* Apply suggestions from code review

* few small fixes

* ruff changes

* correction + test

* fix error

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
Co-authored-by: ilappe <[email protected]>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
…t Pack Update (#30360) (#30461)

* "contribution update to pack "Prisma SASE by Palo Alto Networks""

* Apply suggestions from code review

* few small fixes

* ruff changes

* correction + test

* fix error

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Israel Lappe <[email protected]>
Co-authored-by: ilappe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! External PR post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants