Install xsaim packs with and without dataset #30301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 28 commits
October 18, 2023 16:35
… adding reinstall packs list to collect tests;
|
Please ignore the changes in Packs/qualys/ModelingRules/QualysModelingRules/ file. I will revert them before merging. |
added 8 commits
October 26, 2023 15:30
dantavori
reviewed
Oct 29, 2023
| @@ -136,6 +136,7 @@ validate-content-conf: | |||
| policy: pull-push | |||
| variables: | |||
| KUBERNETES_CPU_REQUEST: 2000m | |||
| EXTRACT_PRIVATE_TESTDATA: "true" | |||
There was a problem hiding this comment.
why if it's already in test_content_on_cloud_server_instances_base?
There was a problem hiding this comment.
I need it in the test collection step. I am collecting packs to reinstall, only if they have test data.
dantavori
approved these changes
Oct 30, 2023
5 tasks
sharonfi99
pushed a commit
that referenced
this pull request
Oct 31, 2023
* adding delete dataset call for cleaning; changing Qualys for testing; adding reinstall packs list to collect tests; * fix pre-commit * auth id should be str * adding logs * adding global varible to download conf * adding more logging * delete logs * add reinstall script * fix path * test without un-installation * test without un-installation * uninstallatio is mandatory * adding got here logging * adding more logs * remove some logs to not wait * save more logs, ucomment * fixes to trigger nightly * revert unnessasary changes * delete logs * testing * revert changes * ruining modeling rules before installation * save second check * check nightly * revert changes * save changed from cr * save changed from cr * revert qualys changes * pre-commit fix
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* adding delete dataset call for cleaning; changing Qualys for testing; adding reinstall packs list to collect tests; * fix pre-commit * auth id should be str * adding logs * adding global varible to download conf * adding more logging * delete logs * add reinstall script * fix path * test without un-installation * test without un-installation * uninstallatio is mandatory * adding got here logging * adding more logs * remove some logs to not wait * save more logs, ucomment * fixes to trigger nightly * revert unnessasary changes * delete logs * testing * revert changes * ruining modeling rules before installation * save second check * check nightly * revert changes * save changed from cr * save changed from cr * revert qualys changes * pre-commit fix
israelpoli
pushed a commit
that referenced
this pull request
May 15, 2024
* adding delete dataset call for cleaning; changing Qualys for testing; adding reinstall packs list to collect tests; * fix pre-commit * auth id should be str * adding logs * adding global varible to download conf * adding more logging * delete logs * add reinstall script * fix path * test without un-installation * test without un-installation * uninstallatio is mandatory * adding got here logging * adding more logs * remove some logs to not wait * save more logs, ucomment * fixes to trigger nightly * revert unnessasary changes * delete logs * testing * revert changes * ruining modeling rules before installation * save second check * check nightly * revert changes * save changed from cr * save changed from cr * revert qualys changes * pre-commit fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6529
Description
Different validation runs on pack installations when datasets exist on tenant and when not. Therefore we need to check the installation with the dataset on the tenant and without.
The flow in xsaim install packs should be:
My changes:
Must have
Builds
Nightly that deletes datasets: https://code.pan.run/xsoar/content/-/jobs/35192465
Branch build that fails as expected: https://code.pan.run/xsoar/content/-/jobs/35464354
Nightly: