[CommonServerPython] Add offset support to lookback #30300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o cs-falcon-fetch-limit-issue
Co-authored-by: Shelly Tzohar <[email protected]>
…rikeFalcon.py Co-authored-by: yuvalbenshalom <[email protected]>
…into cs_falcon_sorting_issue
added 3 commits
October 18, 2023 14:29
ilaner
requested review from
yaakovpraisler and
yuvalbenshalom
and removed request for
yaakovpraisler
|
The commonserverpython changes is on this PR: The changes here will be reverted once this PR is merged |
added 2 commits
October 19, 2023 13:26
ilaner
force-pushed
the
add_offset_support_lookback
branch
from
c09494c
to
39b5bcc
Compare
added 2 commits
October 22, 2023 12:10
yaakovpraisler
approved these changes
Oct 22, 2023
yuvalbenshalom
approved these changes
Oct 23, 2023
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* fixed the parameter that send as a limit * update rn * update test playbook * Update Packs/CrowdStrikeFalcon/ReleaseNotes/1_11_7.md Co-authored-by: Shelly Tzohar <[email protected]> * fixing test playbook * adding sort incidents by the ids order; fix time field issue * rename rn * bump version * added unitest * fix rn * save unitest fix * save format * save unitest fix * update docker * use created timestamp * start_time * RN * Update Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Co-authored-by: yuvalbenshalom <[email protected]> * CR * typo * fixes * fixes * fixes * fixes * sort by created * fixes * fixes * simplify * back to offset * fix offset * remove sort * fixes * RN * RN * fixes * adding tests * update * fixes * fix * fix * fix * add test with offset * add freeze time --------- Co-authored-by: daryakoval <[email protected]> Co-authored-by: Darya Koval <[email protected]> Co-authored-by: Shelly Tzohar <[email protected]> Co-authored-by: yuvalbenshalom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://jira-hq.paloaltonetworks.local/browse/XSUP-24966
Adds support for offset in the lookback.
In case of offset, we will use the old time, and set the offset parameter to the new offset.