Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit - branch builds] Run in nightly mode #30155

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Oct 12, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Before we make the pre-commit step mandatory in PRs, to avoid too much noise from the developers, we will run it with nightly mode, until we align the whole repo with ruff hook.

@mmhw mmhw requested review from kobymeir and ilaner October 12, 2023 19:15
@mmhw mmhw self-assigned this Oct 12, 2023
@mmhw mmhw requested a review from dorschw as a code owner October 24, 2023 08:51
@mmhw mmhw merged commit 579e051 into master Oct 24, 2023
13 checks passed
@mmhw mmhw deleted the MW/pre-commit/Will_run_in_PRs_in_nightly_mode branch October 24, 2023 09:23
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* First commit

* Add demistomock.py to exclude in mypy

* Revert mistake

---------

Co-authored-by: Koby Meir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants