-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added formatSublists param #30146
Merged
Merged
added formatSublists param #30146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahafBenYakir
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a ut for this usecase
JudahSchwartz
force-pushed
the
xdr_remove_non_underscores
branch
from
October 17, 2023 06:54
caa17fa
to
1ea0370
Compare
This reverts commit d0a33c5.
This reverts commit 8452418a6b1c0ec6b779a0c9353d05567615e505.
JudahSchwartz
added
the
ForceMerge
Forcing the merge of the PR despite the build status
label
Oct 22, 2023
Contributor
Author
forcing because tpbs failing in master (timeout) and not related |
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* added formatSublists param * revert bad changes * no underscores * no underscores * negative for bakwards compatibility * added desc * change desc * update readme * format * added rn * variable, nbetter rn * snake case * added test * assert have underscore * no answer for risky is acceptable * format * Revert "format" This reverts commit 3403792a2ef9237d95df62925f06fdc99311df41. * Revert "Revert "format"" This reverts commit 8452418a6b1c0ec6b779a0c9353d05567615e505. * fix playbook * fix playbook * docker image * fixed time * fix mistake * fix pb * account not admin * switch to 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have