Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added formatSublists param #30146

Merged
merged 31 commits into from
Oct 22, 2023
Merged

added formatSublists param #30146

merged 31 commits into from
Oct 22, 2023

Conversation

JudahSchwartz
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a ut for this usecase

Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.py Outdated Show resolved Hide resolved
Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.yml Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/5_2_1.md Outdated Show resolved Hide resolved
@JudahSchwartz JudahSchwartz added the ForceMerge Forcing the merge of the PR despite the build status label Oct 22, 2023
@JudahSchwartz
Copy link
Contributor Author

JudahSchwartz commented Oct 22, 2023

forcing because tpbs failing in master (timeout) and not related

@ShahafBenYakir ShahafBenYakir merged commit ef5849e into master Oct 22, 2023
15 of 16 checks passed
@ShahafBenYakir ShahafBenYakir deleted the xdr_remove_non_underscores branch October 22, 2023 10:47
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* added formatSublists param

* revert bad changes

* no underscores

* no underscores

* negative for bakwards compatibility

* added desc

* change desc

* update readme

* format

* added rn

* variable, nbetter rn

* snake case

* added test

* assert have underscore

* no answer for risky is acceptable

* format

* Revert "format"

This reverts commit 3403792a2ef9237d95df62925f06fdc99311df41.

* Revert "Revert "format""

This reverts commit 8452418a6b1c0ec6b779a0c9353d05567615e505.

* fix playbook

* fix playbook

* docker image

* fixed time

* fix mistake

* fix pb

* account not admin

* switch to 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants