Zoom ask and mirroring #29401
Zoom ask and mirroring #29401
Conversation
|
@tkatzir @yuvalbenshalom @amshamah419 Doc review completed. |
Co-authored-by: ShirleyDenkberg <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
There was a problem hiding this comment.
reviewed the use of each and it looks good.
please complete fixing/replying all of @tkatzir comments.
jbabazadeh
requested review from
dorschw
and removed request for
yucohen and
dorschw
Packs/Zoom/Integrations/Zoom/Zoom.py
Outdated
| auth_failed = False | ||
| v_token = demisto.params().get('verification_token', {}).get('password') | ||
| if 'Basic' not in str(token) and v_token: | ||
| demisto.debug(v_token) |
There was a problem hiding this comment.
Remove this log before merging.
|
@yuvalbenshalom need a force merge in this PR due to validation failed -because JWT authentication method was deprecated by Zoom from June 2023 and not available anymore and removed from this integration [IN129] - You've removed integration parameters, the removed parameters are '{'creds_api_secret', 'creds_api_key', 'apiSecret', 'apiKey'}' [IN116]- |
* send notification * send notification * zoom ask * zoom async * zoom async * zoom readme * secret token for mirroring * send-notification command+ mirroring * unit tests * fix * add context cache * add context cache * zoom ask tests * remove unnecessary debug logs * remove debug logs * CR comments * CR comments * rn * format * zoomask tests * cr * small fix * known_words * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * Update ZoomAsk.yml * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * zoom basic authentication * comments * add certificate to uvicorn to support https * yml * readme --------- Co-authored-by: ShirleyDenkberg <[email protected]>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-6221
Description
A few sentences describing the overall goals of the pull request's commits.
Must have