-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint Firewall - full review on playbooks and massive bug fix #16524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Added missing playbook ReadMe files
…_Rule.yml and Checkpoint_-_Block_IP_-_Custom_Block_Rule_README.md
…sh$install_playbook � Conflicts: � Packs/CheckpointFirewall/Playbooks/Checkpoint_-_Publish&Install_configuration.yml � Packs/CheckpointFirewall/ReleaseNotes/2_1_7.md
…in the FW with IPs + changed the block with custom rule PB + added README file to the new playbook
…sh$install_playbook
…sh$install_playbook � Conflicts: � Packs/CheckpointFirewall/pack_metadata.json
ssokolovich
changed the title
Checkpoint - Publish&Install configuration PB - fixed an issue with deprecated task
Checkpoint Firewall - full review on playbooks and massive bug fix
Dec 29, 2021
David-BMS
reviewed
Dec 29, 2021
Packs/CheckpointFirewall/Playbooks/Checkpoint_-_Block_IP_-_Custom_Block_Rule_README.md
Outdated
Show resolved
Hide resolved
David-BMS
reviewed
Dec 29, 2021
Packs/CheckpointFirewall/Playbooks/Checkpoint_-_Block_IP_-_Custom_Block_Rule.yml
Outdated
Show resolved
Hide resolved
David-BMS
reviewed
Dec 29, 2021
Packs/CheckpointFirewall/Playbooks/Checkpoint_-_Block_IP_-_Append_Group.yml
Show resolved
Hide resolved
David-BMS
reviewed
Dec 29, 2021
Packs/CheckpointFirewall/Playbooks/Checkpoint_-_Block_IP_-_Append_Group.yml
Outdated
Show resolved
Hide resolved
David-BMS
reviewed
Dec 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review comments
…sh$install_playbook
…sh$install_playbook � Conflicts: � Packs/CheckpointFirewall/pack_metadata.json
David-BMS
approved these changes
Jan 4, 2022
…sh$install_playbook � Conflicts: � Packs/CheckpointFirewall/pack_metadata.json
changed block IP to Block IP
block to Block for playbook name
deleted extra space
… into fix_CP_publish$install_playbook
… into fix_CP_publish$install_playbook
edited new playbook description
@ssokolovich made very minor edits to md files, docs approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue #44453
Description
Changed task "checkpoint-logout" to be supported by v2 integration.
Screenshots
Checkpoint_-_Block_URL
Checkpoint_-_Publish Install_configuration
Checkpoint_-Block_IP-_Append_Group
Checkpoint_-Block_IP-_Custom_Block_Rule
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have