Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot be used for Non-Artifact Server deployments #19

Open
mattbibbydw opened this issue Jan 3, 2023 · 0 comments
Open

Cannot be used for Non-Artifact Server deployments #19

mattbibbydw opened this issue Jan 3, 2023 · 0 comments

Comments

@mattbibbydw
Copy link

mattbibbydw commented Jan 3, 2023

Summary

The XSOAR CI/CD deployment model uses two key components; the demisto-sdk and the ContentManagement Content Pack. For single instance environments, the process involves using the demisto-sdk to build custom content packs that are then uploaded to an Artifact Server and then installed via Playbooks from the ContentManagement Content Pack. This process doesn't work for Multitenant environments, as content needs to be installed on the Main Server which cannot execute Playbooks. In these cases, custom content packs need to be installed from the build server using the demisto-sdk upload subcommand. This will not automatically install dependencies from the marketplace. To install those, the MarketPlaceInstallerFromCICD build script needs to be executed using the xsoar_config.json produced by the demisto-sdk.

Problem

The MarketPlaceInstallerFromCICD is just a patched version of the MarketplacePackInstaller script. This automation is used within the ContentManagement playbook designed for the Artifact Server. It uses the demistomock.py, which as the name implies is just a mock library used to emulate the real demisto library imported into automations executed within a container on a demisto server. While the script might print results to stdout, it lacks the capabilities to make an HTTP request... let alone remotely execute the automations required to install content packs from the marketplace. At best, this script can produce a stdout of what it would do if it was executed on a demisto server.

Solution

This is not a viable solution and framing as such is misleading for users who cannot use the Artifact Server deployment model (e.g. anyone with a Multitenant environment). It's impossible for the script to work in its current state without significant refactoring. The script should be removed from this repo and the xsoar-ci-cd docs until a viable solution is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant