Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance "edit name" dialog #2286

Closed
r10s opened this issue Aug 22, 2024 · 0 comments · Fixed by #2288
Closed

enhance "edit name" dialog #2286

r10s opened this issue Aug 22, 2024 · 0 comments · Fixed by #2288
Assignees
Labels
enhancement actually in development, user visible enhancement
Milestone

Comments

@r10s
Copy link
Member

r10s commented Aug 22, 2024

in the "edit contact name" dialog (accessible from "contact profile"), it is a bit unclear, how "Name" us used:

we prepared the following strings for enhancement (this requires the strings to be updated first):

  • use string edit_name_placeholder as a placeholder for the input field ("test" in the screenshot)
  • use edit_name_explain as text below or above the input field
  • both strings take the result of dc_contact_get_auth_name() as a parameter. if empty, use dc_contact_get_addr(). do not use the "display name" 1

the email address and layout can stay as is.

cave: existing strings and placeholders should still be used when the dialog is used as "add contact manually" for non-chatmail accounts

compare deltachat/deltachat-desktop#4090 and deltachat/deltachat-android#3254

Footnotes

  1. the "display name" may be the nickname, this is fine nearly everywhere else and indeed the preferred method to display a name - but not in this special case :)

@r10s r10s added the bug label Aug 22, 2024
@r10s r10s assigned r10s and unassigned r10s Aug 22, 2024
@r10s r10s added enhancement actually in development, user visible enhancement and removed bug labels Aug 22, 2024
@r10s r10s self-assigned this Aug 22, 2024
@r10s r10s changed the title enhance "edit contact name" dialog enhance "edit name" dialog Aug 22, 2024
@zeitschlag zeitschlag added this to the Next Release milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants