-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find an appropriate solution for displaying images #4410
Comments
Basically the main technical issue is that we need to know the size of the message on first render to avoid a message list that jumps around as images are loaded in. Static image sizes or cropping is a reasonable approach for now, but does not look as good for users as it could be. my messages on this topic from the internal group/discussion (about a possible approach to use the dimensions that are provided by core): maybe we could provide a placeholder empty image in the correct dimensions so we would let the browser make the layout calculations This might work (seems like you don't even need base64 encoding):
though I'm not sure whats the best way to load the actual image and replace it, maybe an xhr request do that it is cached, then replace the url or sth. or have two elements and remove the placeholder on load |
But we have the dimensions except for images "the core could not understand" and videos. |
I would suggest: go with the dimensions coming from core and do the needed adaptions in the template (like setting limits to not have too big images or paddings) |
yes, but that's an edge case for which we could have a fallback. And maybe we could tell core to save the dimensions from the ui in these cases? But I think only fallback is just fine. |
Let's continue this discussion once we have a concrete proposal |
I'm not interested in a discussion here at the time, my goal was just to provide more information in the issue thread. |
Ok sure - thanks for that! |
We need a solution to meet following requirements:
Related to:
The text was updated successfully, but these errors were encountered: