makeDisplay() lims don't seem to work for a panel function written in base R

[lhsego]

See this example. It runs without error or warning--but the xlims and ylims are not fixed.

library(trelliscope)
vdbConn("iris_test", name = "iris_test", autoYes = TRUE)
by_species <- divide(iris, by = "Species", update = TRUE)
makeDisplay(by_species,
            name ="iris",
            panelFn = function(x) {plot(x$Sepal.Length, x$Petal.Width); return(NULL)},
            cogFn = function(x) list(Sepal.Width.Mean = cogMean(x$Sepal.Width)),
            lims = list(x = "same", y = "same",
                        prepanelFn = function(x) list(xlim = range(x$Sepal.Length),
                                                      ylim = range(x$Petal.Width))))
view()

[hafen]

Oh good point - it should give a message that it isn't doing anything with limits and that you will need to specify them manually. This is described in the docs somewhere but should be a message too if attempted. There's no way to set the limits in this case unless the user does it manually because we don't have an object to modify. Another strike against base graphics :). Would you like to make this fix? Basically in makeDisplay(), just look at where the panelFn type is found and if it is base, if lims are not free then give a message of "Ignoring 'lims' since panel function is base R graphics" or something like that.

[lhsego]

Sure, I can do that.