chore: cleanup #774
Merged
chore: cleanup #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
wjones127 and
houqp
and removed request for
wjones127
wjones127
reviewed
Aug 31, 2022
There was a problem hiding this comment.
BTW have you double checked that the docs can be built with all storage backend features enabled? I'm not sure this reference still exists for example.
| @@ -97,8 +97,6 @@ pub mod vacuum; | |||
| pub mod checkpoints; | |||
| #[cfg(all(feature = "arrow", feature = "parquet"))] | |||
| pub mod delta_arrow; | |||
| #[cfg(feature = "rust-dataframe-ext")] | |||
There was a problem hiding this comment.
Could you also update the doc comment at the top of the module, which still mentions ADLS2?
wjones127
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes some no longer needed files, as well as the now outdated docs for ADLS Gen2 (we now support blob as well).
Additionally I removed the rust_dataframe support, since the repo has been archived, and tests were removed in the parquet2 PR.
Related Issue(s)
Documentation