Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enforce_retention_duration param to vacuum method #648

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

houqp
Copy link
Member

@houqp houqp commented Jun 19, 2022

Description

This maps to the reference implementation's
spark.databricks.delta.retentionDurationCheck.enabled config.

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left a small comment for the error text.

rust/src/delta.rs Outdated Show resolved Hide resolved
roeap
roeap previously approved these changes Jun 19, 2022
rust/src/delta.rs Outdated Show resolved Hide resolved
@houqp houqp dismissed stale reviews from ghost and roeap via 030e2ad June 19, 2022 19:48
@houqp houqp requested review from roeap and wjones127 June 19, 2022 19:48
@houqp houqp force-pushed the qp_retention branch 2 times, most recently from d7bbe75 to 14ca334 Compare June 19, 2022 20:53
This maps to the reference implementation's
spark.databricks.delta.retentionDurationCheck.enabled config.
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@houqp houqp merged commit 2ac3c3e into delta-io:main Jun 19, 2022
@houqp houqp deleted the qp_retention branch June 19, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants