Remove coupling of DynamoDbLockClient from S3 storage #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosyp
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the refactoring done by #508, the
LockClientused by the S3 storage implementation got coupled to a specific implementation of theLockClient, i.e.DynamoDbLockClient. That doesn't look to be necessary and this PR addresses that by removing that coupling and let the S3 storage support anyLockClient.This is useful in cases where we may not be using S3 in AWS. For example, one could be using MinIO, Hitachi HCP etc which implement the S3 protocol and can be used just like S3. In these cases, a DynamoDb based lock is not required and some other implementation can be used.
Related Issue(s)
Documentation