-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation for load_with_datetime
in Python package.
#411
Conversation
Hmm... the test failed. Let me check it later. |
07216e1
to
eb61b1a
Compare
It's weird, the tests passed on my local machine:
I'm not sure why it's failing in CI. Could @fvaleye @houqp take a look please? |
Learned from |
@zijie0 Thank you for your PR, I added some comments! |
Thanks @fvaleye ! I will go through all the comments today. |
Add tests for bad datetime string format.
bf01688
to
d88ae1d
Compare
Hi @fvaleye , when I run So I added an uninstall step in Makefile, is that ok? |
I think it makes sense to add a new uninstall makefile target. We could also update the install target to use --force-reinstall by default if that helps. Once PyO3/maturin#604 is resolved, we should probably switch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you @zijie0 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect👍
Thanks @zijie0
…-io#411) * Add implementation for `load_with_datetime` in Python package.
Description
We would like to use
load_with_datetime
method implemented in Rust binding in our Python project. Add the implementation in Python package.