Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We pass scheme prefixes (s3://) to PyArrrow #696

Closed
wjones127 opened this issue Jul 17, 2022 · 0 comments · Fixed by #799
Closed

We pass scheme prefixes (s3://) to PyArrrow #696

wjones127 opened this issue Jul 17, 2022 · 0 comments · Fixed by #799
Labels
binding/python Issues for the Python package bug Something isn't working good first issue Good for newcomers

Comments

@wjones127
Copy link
Collaborator

Description

PyArrow Filesystems don't expect paths to be provided as URIs with a scheme prefix (e.g. s3://). The only reason that DeltaTable.to_pyarrow_dataset() works (if you don't pass a filesystem) is that our DeltaStorageHandler accepts URIs.

We need to change so that:

  1. DeltaStorageHandler rejects scheme prefixes
  2. We always pass file paths to PyArrow functions without scheme prefixes (strip them out)

Environment

Delta-rs version:

Binding: Python

Environment:

  • Cloud provider:
  • OS:
  • Other:

Bug

What happened:

See: #689 (comment)

What you expected to happen:

How to reproduce it:

More details:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding/python Issues for the Python package bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: integrate object_store for read/write with pyarrow roeap/delta-rs
1 participant
@wjones127