Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit action field optionality #372

Closed
houqp opened this issue Aug 10, 2021 · 1 comment · Fixed by #380
Closed

Audit action field optionality #372

houqp opened this issue Aug 10, 2021 · 1 comment · Fixed by #380
Assignees
Labels
binding/rust Issues for the Rust crate bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@houqp
Copy link
Member

houqp commented Aug 10, 2021

Environment

Delta-rs version: all

Binding: rust


Bug

What happened:

Some of the fields are incorrectly marked as optional in action.rs

What you expected to happen:

Make sure optionality annotation matches with what's in delta spec and reference implementation: https://github.com/delta-io/delta/blob/master/core/src/main/scala/org/apache/spark/sql/delta/actions/actions.scala

How to reproduce it:

More details:

Follow up from #370

@mosyp
Copy link
Contributor

mosyp commented Aug 30, 2021

We also has to double check changes and do not copy paste 1-to-1 as this example https://github.com/delta-io/delta-rs/pull/417/files/b33124ce41bf4ce9b210fc67a79c8e8590dc72b4#diff-9fb70b66d3f77e15e99399b95228d124db4bd0d898e1e159bf106ccced488332 shows that we could face some issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants