Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup_metadata can potentially delete most recent checkpoint, corrupting table #2174

Closed
cmackenzie1 opened this issue Feb 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cmackenzie1
Copy link
Contributor

Environment

Delta-rs version: v0.16 (havent' tried latest version yet)

Binding: rust


Bug

What happened:
The most recent checkpoint file was deleted during regularly scheduled vacuum/cleanup, corrupting the table. I ran into this issue but haven't had time to look into it. Filing this so it doesn't get forgotten :)

What you expected to happen:
Most recent checkpoint should never be deleted.

How to reproduce it:

  1. Create table and checkpoint it
  2. Set log retention period to 1s
  3. Wait 1s and then run cleanup_metadata
  4. Most recent checkpoint is deleted.

More details:

@cmackenzie1 cmackenzie1 added the bug Something isn't working label Feb 6, 2024
@ion-elgreco
Copy link
Collaborator

ion-elgreco commented Feb 6, 2024

@cmackenzie1 recently there was a bugfix for cleanup_metadata, can you try 0.17 or use the latest python version?

@cmackenzie1
Copy link
Contributor Author

@ion-elgreco yeah, looks like it was fixed in 25040b8!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants