Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARN Could not load all certificates - BadDER #1224

Closed
kukushking opened this issue Mar 15, 2023 · 2 comments · Fixed by #1244
Closed

WARN Could not load all certificates - BadDER #1224

kukushking opened this issue Mar 15, 2023 · 2 comments · Fixed by #1244
Labels
bug Something isn't working

Comments

@kukushking
Copy link

Environment

Delta-rs version: 0.8.0

Binding: Python (3.10.8)

Environment:

  • Cloud provider: AWS
  • OS: OSX
  • Other:

Bug

What happened:
After upgrading to 0.8.0, all operations display the following warning:

[2023-03-15T09:59:13Z WARN  hyper_rustls::connector] Could not load all certificates: Custom { kind: InvalidData, error: Custom { kind: InvalidData, error: BadDER } }

Looks like deltalake is not able to load certificates in the native OSX truststore. I do have a few unsigned/self-signed certs in my truststore so that might be it, but in that case I'd expect a message saying it's not able to validate it, not "bad" cert.

What you expected to happen:

How to reproduce it:

More details:

@kukushking kukushking added the bug Something isn't working label Mar 15, 2023
@wjones127
Copy link
Collaborator

Thanks for reporting this. We switched the default our build system from openssl to rustls, but it wasn't entirely intentional to switch the Python package.

I think we should switch back in the next version. If need be, I can do a bugfix release that switches back too.

There are some workarounds for MacOS described here: rustls/rustls#127 (comment) Does that fix it for you?

@kukushking
Copy link
Author

Thanks @wjones127, no need for bugfix release as it's not a severe issue. I don't want to touch the certs so it's fine with the warning. Just opened so you're aware of this. Thanks!

houqp pushed a commit that referenced this issue Mar 26, 2023
# Description

We changed default to make our workspace harmonious, but didn't mean to
change this for the Python release.

# Related Issue(s)

- closes #1224


# Documentation

<!---
Share links to useful documentation
--->
rtyler added a commit that referenced this issue Sep 6, 2024
…inux release

This change enables the use of Rustls for the manylinux Python wheel,
which was originally disabled in #1224. That issue was only affecting MacOS
and has likely since been resolved.

The switch from openssl motivated by the issue described in
openssl/openssl#25367

Closes #2848
rtyler added a commit that referenced this issue Sep 6, 2024
…inux release

This change enables the use of Rustls for the manylinux Python wheel,
which was originally disabled in #1224. That issue was only affecting MacOS
and has likely since been resolved.

The switch from openssl motivated by the issue described in
openssl/openssl#25367

Closes #2848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants