use rustls for delta checkpoint lambda

also test rustls feature in CI
delta-io · Sep 26, 2022 · 197c516 · 197c516
1 parent 0b12e32
commit 197c516
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 12 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -105,9 +105,12 @@ jobs:
       - name: Start emulated services
         run: docker-compose up -d
 
-      - name: Run tests
+      - name: Run tests with default ssl
         run: |
           cargo test --features integration_test,azure,s3,gcs,datafusion-ext
+      - name: Run tests with rustls
+        run: |
+          cargo test --features integration_test,s3-rustls,datafusion-ext
 
   paruqet2_test:
     runs-on: ubuntu-latest

diff --git a/aws/delta-checkpoint/Cargo.toml b/aws/delta-checkpoint/Cargo.toml
@@ -23,12 +23,12 @@ tokio-stream = { version = "0", features = ["fs"] }
 [dependencies.deltalake]
 path = "../../rust"
 version = "0"
-features = ["s3"]
+features = ["s3-rustls"]
 
 [dev-dependencies]
-rusoto_core = "0.48"
+rusoto_core = { version = "0.48", default-features = false, features = ["rustls"] }
 rusoto_credential = "0.48"
-rusoto_s3 = "0.48"
+rusoto_s3 = { version = "0.48", default-features = false, features = ["rustls"] }
 
 [[bin]]
 name = "bootstrap"

diff --git a/rust/tests/integration_commit.rs b/rust/tests/integration_commit.rs
@@ -10,30 +10,30 @@ use std::collections::HashMap;
 
 #[tokio::test]
 #[serial]
-async fn test_commit_tables_local() -> TestResult {
-    Ok(commit_tables(StorageIntegration::Local).await?)
+async fn test_commit_tables_local() {
+    commit_tables(StorageIntegration::Local).await.unwrap();
 }
 
 #[cfg(any(feature = "s3", feature = "s3-rustls"))]
 #[tokio::test]
 #[serial]
-async fn test_commit_tables_aws() -> TestResult {
+async fn test_commit_tables_aws() {
     std::env::set_var("AWS_S3_LOCKING_PROVIDER", "dynamodb");
-    Ok(commit_tables(StorageIntegration::Amazon).await?)
+    commit_tables(StorageIntegration::Amazon).await.unwrap();
 }
 
 #[cfg(feature = "azure")]
 #[tokio::test]
 #[serial]
-async fn test_commit_tables_azure() -> TestResult {
-    Ok(commit_tables(StorageIntegration::Microsoft).await?)
+async fn test_commit_tables_azure() {
+    commit_tables(StorageIntegration::Microsoft).await.unwrap();
 }
 
 #[cfg(feature = "gcs")]
 #[tokio::test]
 #[serial]
-async fn test_commit_tables_gcp() -> TestResult {
-    Ok(commit_tables(StorageIntegration::Google).await?)
+async fn test_commit_tables_gcp() {
+    commit_tables(StorageIntegration::Google).await.unwrap();
 }
 
 #[cfg(any(feature = "s3", feature = "s3-rustls"))]