Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decimal in get_testing_kernel_expression and visitor printing #456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OussamaSaoudi-db
Copy link
Collaborator

What changes are proposed in this pull request?

This PR changes the Decimal in get_testing_kernel_expression to have a precision larger than the scale, which is a requirement of Decimals. Moreover and the existing behaviour may cause errors in engines that check that Decimals are well-formed.

The child list parameter name in visit_literal_struct is renamed to be consistent with the other visitor.

Finally, the printing is patched up in expression_print.h to be consistent with the order in the Decimal struct.

How was this change tested?.

I ran the visit-expression test suite with the new expected output.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.41%. Comparing base (4466509) to head (9fcc430).

Files with missing lines Patch % Lines
ffi/src/test_ffi.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   78.41%   78.41%           
=======================================
  Files          55       55           
  Lines       11806    11806           
  Branches    11806    11806           
=======================================
  Hits         9258     9258           
  Misses       2041     2041           
  Partials      507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OussamaSaoudi-db OussamaSaoudi-db changed the title Fix precision smaller than scale and printing Fix decimal in get_testing_kernel_expression and visitor printing Nov 7, 2024
@OussamaSaoudi-db OussamaSaoudi-db marked this pull request as ready for review November 7, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant