Fix decimal in get_testing_kernel_expression
and visitor printing
#456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR changes the
Decimal
inget_testing_kernel_expression
to have a precision larger than the scale, which is a requirement ofDecimal
s. Moreover and the existing behaviour may cause errors in engines that check thatDecimal
s are well-formed.The child list parameter name in
visit_literal_struct
is renamed to be consistent with the other visitor.Finally, the printing is patched up in
expression_print.h
to be consistent with the order in theDecimal
struct.How was this change tested?.
I ran the visit-expression test suite with the new expected output.