Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFI string handling should never panic #446

Open
scovich opened this issue Oct 29, 2024 · 0 comments
Open

FFI string handling should never panic #446

scovich opened this issue Oct 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@scovich
Copy link
Collaborator

scovich commented Oct 29, 2024

Describe the bug

Several FFI functions will panic if an internal operation ever returns an Err:

  • set_builder_option
  • get_from_map
  • visit_scan_data

We should probably change their signatures to return ExternResult so the engine can decide how to handle the problem.

To Reproduce

N/A - code inspection

Expected behavior

Se should only call unwrap on a Result if we're sure it can never be Err.

Additional context

No response
@scovich scovich added the bug Something isn't working label Oct 29, 2024
@scovich scovich mentioned this issue Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scovich