Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: idrac_server_config_profile(share_name) doesn't support for IPv6 address #474

Closed
ruic11111 opened this issue Feb 16, 2023 · 1 comment · Fixed by #478
Closed

[BUG]: idrac_server_config_profile(share_name) doesn't support for IPv6 address #474

ruic11111 opened this issue Feb 16, 2023 · 1 comment · Fixed by #478
Labels
needs-triage Issue requires triage. type/bug Something isn't working

Comments

@ruic11111
Copy link

ruic11111 commented Feb 16, 2023

Bug Description

When I specified the nfs server with IPv6 address in share_name of idrac_server_config_profile, the process failed.
I confirmed that following part can't handle IPv6 address correctly.

#idrac_server_config_profile.py

    if ":" in share_name:
        nfs_split = share_name.split(":")
        share = {"share_ip": nfs_split[0], "share_name": nfs_split[1], "share_type": "NFS"}

IP address(share_ip) and share name(share_name) are separated by the first colon,
so if IPv6 address was designated, share_ip and share_name cannot be obtained correctly.

I have confirmed that it works if the above part is changed as follows.

    if ":/" in share_name:
        nfs_split = share_name.rsplit(":",1)
        share = {"share_ip": nfs_split[0], "share_name": nfs_split[1], "share_type": "NFS"}

Component or Module Name

idrac_server_config_profile

Ansible Version

any

Python Version

any

iDRAC/OME/OME-M version

any

Operating System

any

Playbook Used

tasks:

  • name: Import SCP from a network share and wait for this job to get completed
    idrac_server_config_profile_custom:
    idrac_ip: '{{ idrac_ip }}'
    idrac_user: '{{ idrac_user }}'
    idrac_password: '{{ idrac_password }}'
    command: 'import'
    share_name: 'fd01::3:/share' #IPv6 address
    scp_file: '{{ scp_config }}'
    scp_components: 'ALL'
    job_wait: True
    validate_certs: false

Logs

fatal: [idracca]: FAILED! => {"attempts": 2, "changed": false, "error_info": {"error": {"@Message.ExtendedInfo": [{"Message": "The property ShareName is a required property and must be included in the request.", "MessageArgs": ["ShareName"], "[email protected]": 1, "MessageId": "Base.1.12.PropertyMissing", "RelatedProperties": ["#/ShareParameters/ShareName"], "[email protected]": 1, "Resolution": "Ensure that the property is in the request body and has a valid value and resubmit the request if the operation failed.", "Severity": "Warning"}], "code": "Base.1.12.GeneralError", "message": "A general error has occurred. See ExtendedInfo for more information"}}, "msg": "HTTP Error 400: Bad Request"}

Steps to Reproduce

run playbook as mentioned above

Expected Behavior

work correctly

Actual Behavior

playbook(module) failed

Screenshots

No response

Additional Information

Please let me know if this feature is planned to be implemented in the future.

@ruic11111 ruic11111 added needs-triage Issue requires triage. type/bug Something isn't working labels Feb 16, 2023
@sachin-apa
Copy link
Collaborator

@ruic11111 Thanks for reporting the bug, we will have this fixed as part of the Feb month release.

@sachin-apa sachin-apa linked a pull request Feb 22, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Issue requires triage. type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants