Skip to content
This repository has been archived by the owner on Jul 23, 2021. It is now read-only.

Provider integration is broken for serverless >2.30.3 #175

Open
dls314 opened this issue Apr 19, 2021 · 1 comment
Open

Provider integration is broken for serverless >2.30.3 #175

dls314 opened this issue Apr 19, 2021 · 1 comment

Comments

@dls314
Copy link

dls314 commented Apr 19, 2021

The search for error message contents from the provider call at https://github.com/deliveryhero/serverless-aws-documentation/blob/master/src/documentation.js#L107 is broken in serverless > 2.30.3 by the change here serverless/serverless@89b813d

@ottopecz
Copy link

ottopecz commented Apr 26, 2021

The actual error object thrown by the serverless aws provider has changed in the above mentioned versions.

When expecting an error it's better to rely on something more abstract and formal than the message of the error. Good choices might include the code or the statusCode

We published a fix and we plan to maintain the package.
https://www.npmjs.com/package/@kakkuk/serverless-aws-apigateway-documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants