Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

feat(Makefile): let each project manage how it builds #653

Merged
merged 1 commit into from
Apr 3, 2014

Conversation

bacongobbler
Copy link
Member

Instead of hardcoding docker build -t deis/<component> ., we should let each project manage how they build themselves by handing it over to their make build command.

@mboersma
Copy link
Member

My concern is that if we do allow container projects leeway over what make build does, it will be harder to integrate with deis/tester, which benefits from the current standardization: https://github.com/deis/tester/blob/master/master/master.cfg#L104

In the CI environment we are building each image with the same name as its subfolder and adding a build-specific tag, for example deis/controller:tester-11, then using that tag to run and test it. This could be trickier if we merge this PR.

@mboersma
Copy link
Member

mboersma commented Apr 2, 2014

Looking at this again, it's just a change to the master build target, and each container already has its own make build, so the deis/tester is already making assumptions that could be broken. It will be deis/tester's responsibility to keep its strategy current regardless. See https://github.com/deis/tester/issues/17.
LGTM.

@mboersma mboersma changed the title let each project manage how they build feat(Makefile): let each project manage how it builds Apr 2, 2014
@carmstrong
Copy link
Contributor

LGTM

bacongobbler pushed a commit that referenced this pull request Apr 3, 2014
feat(Makefile): let each project manage how it builds
@bacongobbler bacongobbler merged commit 8c0af54 into master Apr 3, 2014
@bacongobbler bacongobbler deleted the makefile branch April 3, 2014 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants