-
Notifications
You must be signed in to change notification settings - Fork 797
Move slugbuilder-hook from cookbook into bin
#376
Comments
…controller_env.sh primarily for use by slugbuilder. deis/deis#376
These commits are work in progress, it should be complete I just haven't tested it. Which brings me back to #319. I still don't think the docs are clear on how to run the tests. For a start they miss out the step of using venv and installing the Right now I'm stuck with the problem of having the permission to create the test database. I tried editing Oh and whilst I remember when updating my controller VM with |
Whatever environment you're working in should work for you. I do this all locally (Virtualenv and Sublime Text keyboard shortcuts FTW). I've worked on projects where any change you make to the code has to be |
@bacongobbler oh yeah, I know what you mean about the pain of SCP :'( Hooray for ST shortcuts and Travis CI! BTW I've made a stab at tweaking the tests to run in a vagrant environment #408. Very much just ideas to consider. |
…controller_env.sh primarily for use by slugbuilder. deis/deis#376
I fixed it. All it need was to move the write_file() call inside the iteration loop tombh/deis-cookbook@c063e08 |
Excellent. I will try again to test and merge this tonight. |
Right now the slugbuilder-hook is an ERB template in the deis-cookbook. As @tombh pointed out, it would be easier to hack on if we moved it to
bin
, and retrieved @controller_dir and @slug_dir from the shell environment.Note that the hook is run as the git user, so there may be some hoops to jump through re: permissions.
The text was updated successfully, but these errors were encountered: