Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Missing global settings customization in helm chart #1301

Open
felixbuenemann opened this issue May 24, 2017 · 1 comment
Open

Missing global settings customization in helm chart #1301

felixbuenemann opened this issue May 24, 2017 · 1 comment

Comments

@felixbuenemann
Copy link
Contributor

There is currently no way to set the following global controller environment variables without customizing helm charts:

  • DEIS_DEPLOY_BATCHES
  • DEIS_DEPLOY_TIMEOUT
  • KUBERNETES_DEPLOYMENTS_REVISION_HISTORY_LIMIT
  • KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS

(Probably more, all of the above can be overridden using the equally named environnment variables in each app.)

It would be great if the controller helm chart had a environment_variables section to allow setting these variables, similar to router.deployment_annotations in the deis/router chart:

controller:
  environment_variables:
    KUBERNETES_DEPLOYMENTS_REVISION_HISTORY_LIMIT: "10"
    KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS: "60"

Alternatively separate values could be added for each setting, but I think this approach is more flexible and avoids the need to document rarely customized settings.

@Cryptophobia
Copy link
Contributor

This issue was moved to teamhephy/controller#22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants