Skip to content
This repository has been archived by the owner on Oct 10, 2021. It is now read-only.

Update path to istanbul assets #245

Closed
kof opened this issue Oct 25, 2015 · 12 comments
Closed

Update path to istanbul assets #245

kof opened this issue Oct 25, 2015 · 12 comments

Comments

@kof
Copy link

kof commented Oct 25, 2015

Files like this one are moved in instanbul to assets dir.

zuul/node_modules/istanbul-middleware/node_modules/istanbul/lib/vendor/prettify.css

@kof kof changed the title Update path to istanbul files Update path to istanbul assets Oct 25, 2015
@defunctzombie
Copy link
Owner

@vvo ping, something from a recent update?

@vvo
Copy link
Collaborator

vvo commented Oct 26, 2015

@lpinca any hints? You did an istanbul related PR.

@vvo
Copy link
Collaborator

vvo commented Oct 26, 2015

Also @kof I am not sure to understand what you are asking for, can you be more specific on what's wrong?

@kof
Copy link
Author

kof commented Oct 26, 2015

just install the latest version, remove node_modules and you will get it when you run some tests locally, it will try to load some files from a non-existing location.

@vvo
Copy link
Collaborator

vvo commented Oct 26, 2015

I still don't get how to fix this eheh. What to fix

@lpinca
Copy link
Contributor

lpinca commented Oct 27, 2015

I can reproduce this and yes it is caused by the istanbul-middleware update (my pr).
If you pin down istanbul to version 0.2.x in instabul-middleware, it works. A newer istanbul generates this issue.

I will try to investigate as soon as I find some time.

To repoduce the issue:

  1. Install latest zuul
  2. Run zuul --local 8080 -- test.js
  3. Open the url shown by zuul in a browser

@defunctzombie
Copy link
Owner

@vvo lets revert the update since it seems to break for users and needs more testing

@vvo
Copy link
Collaborator

vvo commented Oct 27, 2015

Allright

@vvo
Copy link
Collaborator

vvo commented Oct 27, 2015

Ok published 3.7.2 with reverted istanbul-middleware, @lpinca would be good to get your insights when you have time :D

@lpinca
Copy link
Contributor

lpinca commented Oct 27, 2015

@vvo sure, I will take a look, I just have to find a little time 😄

@lpinca
Copy link
Contributor

lpinca commented Oct 27, 2015

gotwarlost/istanbul#467
gotwarlost/istanbul-middleware#26

[email protected] is broken, we have to wait for the next version.

@vvo
Copy link
Collaborator

vvo commented Oct 27, 2015

Nice, open a new PR when ready then :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants