Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLLM Compatibility Update #222

Merged
merged 9 commits into from
Nov 1, 2024
Merged

VLLM Compatibility Update #222

merged 9 commits into from
Nov 1, 2024

Conversation

wongjingping
Copy link
Collaborator

@wongjingping wongjingping commented Nov 1, 2024

Changes

  • update api_server to be compatible with latest version of vllm
  • removed deprecated param cot_table_alias from run_model_cot.sh

Testing

Tested with:

./run_model_cot.sh defog/sqlcoder-8b-dare-ties

Results changed slightly due to running on an A40 with more memory, but overall still similar to past runs:

Model sqlcoder-8b-dare-ties
V1 Accuracy 88.10%
Basic Accuracy 100%
Advanced Accuracy 90.62%
Overall Accuracy 90.1%

Copy link
Contributor

@Muhammad18557 Muhammad18557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Will also pin the version in requirements.txt if you think this post1 version will be the standard. Or can keep as it is for backward compatibility!

@wongjingping
Copy link
Collaborator Author

Cool, thanks! Will also pin the version in requirements.txt if you think this post1 version will be the standard. Or can keep as it is for backward compatibility!

Thanks for the suggestion! We have some environments (e.g. the lambda labs H100) where it might not be convenient to upgrade the version due to existing hosted endpoints/models that we would need to test for regressions, hence will not pin the vllm version for now. 😄

pysqlite3
sentence_transformers
snowflake-connector-python
spacy==3.7.2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so after a lot of experimentation it turns out that spacy==3.7 is required for the tests to work as before

@wongjingping wongjingping merged commit 0262d0e into main Nov 1, 2024
2 checks passed
@wongjingping wongjingping deleted the jp/vllm branch November 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants