Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add configurable backoff and retries for Zarf operations #2345

Merged
merged 1 commit into from
Mar 8, 2024
Merged

feat: add configurable backoff and retries for Zarf operations #2345

merged 1 commit into from
Mar 8, 2024

Conversation

Racer159
Copy link
Contributor

@Racer159 Racer159 commented Mar 1, 2024 •
edited by Noxsios
Loading

Description

This adds --backoff and --retries to package operations to allow those to be configured.

Related Issue

Relates to #2104

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@Racer159 Racer159 added the needs-tests PR Label - Tests required to merge label Mar 1, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited
Loading

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 1d4e8d3
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/65ea43d3796c0d0008f69c98

@eddiezane eddiezane marked this pull request as draft March 1, 2024 16:58
@eddiezane eddiezane force-pushed the hotfix-add-backoff-retries branch 2 times, most recently from 877807b to 07b5228 Compare March 2, 2024 00:29
@eddiezane eddiezane force-pushed the hotfix-add-backoff-retries branch 2 times, most recently from 622b4f9 to ced1eb1 Compare March 4, 2024 21:27
@eddiezane eddiezane removed the needs-tests PR Label - Tests required to merge label Mar 4, 2024
@eddiezane eddiezane marked this pull request as ready for review March 4, 2024 21:27
@eddiezane
Copy link
Member

Hmmmm

image

@eddiezane
Copy link
Member

eddiezane commented Mar 4, 2024 •
edited
Loading

Hmmmm

Ahh the error doesn't actually contain that message. It only contains "exit status 1". Changed the test.

Racer159
Racer159 commented Mar 5, 2024
View reviewed changes
Copy link
Contributor Author

@Racer159 Racer159 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me fwiw (will need another review given I wrote half of it)

Noxsios
Noxsios previously requested changes Mar 5, 2024
View reviewed changes
src/pkg/utils/helpers/misc.go Show resolved Hide resolved
src/pkg/utils/helpers/misc.go Show resolved Hide resolved
src/test/e2e/36_custom_retries_test.go Show resolved Hide resolved
src/internal/packager/helm/chart.go Show resolved Hide resolved
@eddiezane eddiezane requested a review from Noxsios March 7, 2024 22:47
@Noxsios Noxsios dismissed their stale review March 8, 2024 03:58

blocking issues resolved

@Noxsios Noxsios merged commit e5cbe40 into main Mar 8, 2024
30 checks passed
@Noxsios Noxsios deleted the hotfix-add-backoff-retries branch March 8, 2024 04:02
@Noxsios Noxsios mentioned this pull request Mar 8, 2024
Closed
@eddiezane eddiezane mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiezane eddiezane eddiezane left review comments

@Noxsios Noxsios Noxsios approved these changes

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

@lucasrod16 lucasrod16 Awaiting requested review from lucasrod16

@AustinAbro321 AustinAbro321 Awaiting requested review from AustinAbro321

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Racer159 @eddiezane @Noxsios