-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interface validation checks in ci #211
Comments
Updating this ticket with some new changes - Istio now runs in all single package tests but we still have similar considerations for testing interactions with other pieces of the stack like monitoring/keycloak. One avenue to help here is splitting validation into two separate test runs
Individual packages could then have tasks like: tasks:
- name: single-pkg-validate
actions:
- cmd: <hit grafana VS>
- cmd: <basic cypress test?>
- name: all-validate
actions:
- task: single-pkg-validate
- cmd: <sso login check>
- cmd: <validate grafana dashboards / datasources> This would allow us to reuse tests where it makes sense but also allow augmenting our full test suite without causing issues on the single package side. |
Going to close this for now @UnicornChance - I think the intent with splitting up tests will be met as we build out the e2e tests. Also worth noting that all dependencies deploy in our new layer CI, so things like SSO logins can always be checked. |
Expected result
Grafana, Neuvector and Keycloak all have interface validation checks in their respective src/tasks.yaml. At this time they are commented out because CI does not create istio for the single package tests.
Actual Result
Interface validations are not passing in ci, either they need to pass or not run with some sort of conditional logic. Their ideal for local testing, so maintaining them is worth the hassle.
Related Issue
defenseunicorns/maru-runner#66
The text was updated successfully, but these errors were encountered: