Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn devs when their feature branches may be too large #1571

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

samayer12
Copy link
Collaborator

@samayer12 samayer12 commented Dec 12, 2024

Description

Collectively, the Pepr team has reviewed some large PRs lately (e.g., #1262, #1543, #1539, #1396, #1402, #1407). We prefer several smaller PRs to reduce the amount of time spent in code-review and to encourage working in small chunks. This script is an example of a pre-push hook using Husky that warns devs when their branch may be too large.

This PR does not fulfill a need in the backlog, and does not need to be merged. Rather, it's offered as an example to how a Pepr developer might use a similar script for their local development.

Related Issue

None.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.22%. Comparing base (34f4e50) to head (5cdb69e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1571   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          42       42           
  Lines        1896     1896           
  Branches      427      435    +8     
=======================================
  Hits         1521     1521           
- Misses        346      373   +27     
+ Partials       29        2   -27     

see 8 files with indirect coverage changes

@samayer12 samayer12 marked this pull request as ready for review December 12, 2024 22:42
@samayer12 samayer12 requested a review from a team as a code owner December 12, 2024 22:42
@samayer12 samayer12 self-assigned this Dec 12, 2024
@samayer12
Copy link
Collaborator Author

samayer12 commented Dec 13, 2024

@cmwylie19, what do you think about making the pre-push script an opt-in via an environment variable? We don't want to force everyone to work that way since it's highly-opinionated and hooks can be bypassed with --no-verify anyways.

@cmwylie19
Copy link
Collaborator

@cmwylie19, what do you think about making the pre-push script an opt-in via an environment variable? We don't want to force everyone to work that way since it's highly-opinionated and hooks can be bypassed with --no-verify anyways.

Yeah that can work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants