-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: warn devs when their feature branches may be too large #1571
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1571 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 42 42
Lines 1896 1896
Branches 427 435 +8
=======================================
Hits 1521 1521
- Misses 346 373 +27
+ Partials 29 2 -27 |
@cmwylie19, what do you think about making the pre-push script an opt-in via an environment variable? We don't want to force everyone to work that way since it's highly-opinionated and hooks can be bypassed with |
Yeah that can work |
Description
Collectively, the Pepr team has reviewed some large PRs lately (e.g., #1262, #1543, #1539, #1396, #1402, #1407). We prefer several smaller PRs to reduce the amount of time spent in code-review and to encourage working in small chunks. This script is an example of a pre-push hook using Husky that warns devs when their branch may be too large.
This PR does not fulfill a need in the backlog, and does not need to be merged. Rather, it's offered as an example to how a Pepr developer might use a similar script for their local development.
Related Issue
None.
Type of change
Checklist before merging